Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main-v0.13.2 into main #337

Merged

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Aug 6, 2024

This change is Reviewable

@dorimedini-starkware
Copy link
Collaborator Author

Src Dst .github/workflows/main.yml
Src Dst crates/mempool_test_utils/Cargo.toml
Src Dst crates/mempool_types/Cargo.toml

@dorimedini-starkware dorimedini-starkware self-assigned this Aug 6, 2024
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, 13 of 28 files at r2, 12 of 14 files at r3, 17 of 17 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

Signed-off-by: Dori Medini <dori@starkware.co>
Copy link
Contributor

@alon-dotan-starkware alon-dotan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 14 files at r3, 1 of 17 files at r4, 1 of 3 files at r5.
Reviewable status: 43 of 45 files reviewed, all discussions resolved (waiting on @dafnamatsry and @dorimedini-starkware)

Copy link

github-actions bot commented Aug 6, 2024

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.094 ms 66.194 ms 66.301 ms]
change: [-7.0395% -3.9510% -1.3501%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 43 of 45 files reviewed, all discussions resolved (waiting on @dafnamatsry)

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.73%. Comparing base (b46361e) to head (09cd2b3).
Report is 2 commits behind head on main.

Files Patch % Lines
.../blockifier/src/execution/entry_point_execution.rs 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   76.74%   76.73%   -0.01%     
==========================================
  Files         318      318              
  Lines       34583    34569      -14     
  Branches    34583    34569      -14     
==========================================
- Hits        26540    26527      -13     
  Misses       5755     5755              
+ Partials     2288     2287       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r5.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware merged commit 8a94052 into main Aug 6, 2024
29 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants