Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): recompile cairo1 contracts #343

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Aug 6, 2024

This change is Reviewable

Signed-off-by: Dori Medini <dori@starkware.co>
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @aner-starkware and @TzahiTaub)


crates/blockifier/src/execution/syscalls/syscalls_test.rs line 0 at r1 (raw file):
the numbers here are purely for sanity - small changes are fine.
if they become zero, or drastically change, we may have an issue

Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)

@dorimedini-starkware dorimedini-starkware merged commit 9dcfd30 into main Aug 7, 2024
25 checks passed
@dorimedini-starkware dorimedini-starkware deleted the dori/recompile-cairo1-contracts-2 branch August 7, 2024 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants