Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): add charge fee flag to execute #345

Closed
wants to merge 1 commit into from

Conversation

meship-starkware
Copy link
Contributor

@meship-starkware meship-starkware commented Aug 7, 2024

This change is Reviewable

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 12 lines in your changes missing coverage. Please review.

Project coverage is 76.51%. Comparing base (8f66c2d) to head (fc2c605).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/native_blockifier/src/py_block_executor.rs 0.00% 6 Missing ⚠️
.../blockifier/src/blockifier/transaction_executor.rs 66.66% 3 Missing ⚠️
...es/blockifier/src/blockifier/stateful_validator.rs 50.00% 0 Missing and 2 partials ⚠️
crates/native_blockifier/src/py_validator.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
+ Coverage   76.45%   76.51%   +0.05%     
==========================================
  Files         329      329              
  Lines       34822    34938     +116     
  Branches    34822    34938     +116     
==========================================
+ Hits        26623    26732     +109     
- Misses       5906     5913       +7     
  Partials     2293     2293              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meship-starkware meship-starkware force-pushed the meship/blockifier/add_charge_fee_flag branch 3 times, most recently from 40b27f8 to af05b89 Compare August 8, 2024 11:36
@meship-starkware meship-starkware changed the title chore(blockifier): Add charge fee flag to execute chore(blockifier): add charge fee flag to execute Aug 8, 2024
@meship-starkware meship-starkware force-pushed the meship/blockifier/add_charge_fee_flag branch 2 times, most recently from fc2c605 to 4d3a124 Compare August 11, 2024 08:48
@meship-starkware meship-starkware force-pushed the meship/blockifier/add_charge_fee_flag branch from 4d3a124 to 511d481 Compare August 12, 2024 10:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant