-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main-v0.13.2 into main #418
Merge main-v0.13.2 into main #418
Conversation
<!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/starkware-libs/sequencer/311) <!-- Reviewable:end -->
<!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/starkware-libs/sequencer/313) <!-- Reviewable:end -->
<!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/starkware-libs/sequencer/315) <!-- Reviewable:end -->
<!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/starkware-libs/sequencer/316) <!-- Reviewable:end -->
<!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/starkware-libs/sequencer/317) <!-- Reviewable:end -->
Signed-off-by: Dori Medini <dori@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 11 files at r6, 2 of 4 files at r8, 71 of 74 files at r9, 7 of 7 files at r10, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
Signed-off-by: Dori Medini <dori@starkware.co>
Benchmark movements: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
=======================================
Coverage 76.01% 76.01%
=======================================
Files 329 329
Lines 35296 35296
Branches 35296 35296
=======================================
Hits 26832 26832
Misses 6163 6163
Partials 2301 2301 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r11, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @dorimedini-starkware and @TzahiTaub)
Cargo.lock
line 6287 at r10 (raw file):
<<<<<<< HEAD ||||||| 8134c27b "clap 4.5.4",
You don't want to specifiy the version?
Code quote:
"clap 4.5.4",
.github/workflows/blockifier_compiled_cairo.yml
line 19 at r10 (raw file):
||||||| 8134c27b ======= - 'crates/blockifier/feature_contracts/cairo0/**'
Can you explain this? were your cairo1-compilation PRs over main
?
Code quote:
- 'crates/blockifier/feature_contracts/cairo0/**'
.github/workflows/blockifier_compiled_cairo.yml
line 35 at r10 (raw file):
- 'crates/blockifier/tests/requirements.txt' ||||||| 8134c27b - 'crates/blockifier/feature_contracts/cairo0/**'
ditto
Code quote:
- 'crates/blockifier/feature_contracts/cairo0/**'
.github/workflows/blockifier_compiled_cairo.yml
line 95 at r10 (raw file):
pip install -r crates/blockifier/tests/requirements.txt; cargo test -p blockifier --test feature_contracts_compatibility_test --features testing -- --include-ignored >>>>>>> origin/main-v0.13.2
ditto
Code quote:
||||||| 8134c27b
- run:
pip install -r crates/blockifier/tests/requirements.txt;
cargo test verify_feature_contracts -- --include-ignored
=======
- run:
pip install -r crates/blockifier/tests/requirements.txt;
cargo test -p blockifier --test feature_contracts_compatibility_test --features testing -- --include-ignored
>>>>>>> origin/main-v0.13.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @amosStarkware and @TzahiTaub)
Cargo.lock
line 6287 at r10 (raw file):
Previously, amosStarkware wrote…
You don't want to specifiy the version?
this version was only specified because the committer used a different version; we aligned the clap
version all across the workspace so no more explicit version required.
.github/workflows/blockifier_compiled_cairo.yml
line 19 at r10 (raw file):
Previously, amosStarkware wrote…
Can you explain this? were your cairo1-compilation PRs over
main
?
yes. they weren't needed on main-v0.13.2
.github/workflows/blockifier_compiled_cairo.yml
line 35 at r10 (raw file):
Previously, amosStarkware wrote…
ditto
ditto
.github/workflows/blockifier_compiled_cairo.yml
line 95 at r10 (raw file):
Previously, amosStarkware wrote…
ditto
the correct command is:
cargo test -p blockifier --test feature_contracts_compatibility_test --features testing -- --include-ignored
was fixed on both main and main-v0.13.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TzahiTaub)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)
This change is