Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(fee): add calldata and signature l2 cost #460

Conversation

nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Aug 14, 2024

This change is Reviewable

@nimrod-starkware nimrod-starkware self-assigned this Aug 14, 2024
@nimrod-starkware nimrod-starkware marked this pull request as ready for review August 14, 2024 13:14
Copy link
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @TzahiTaub)


crates/blockifier/src/transaction/objects.rs line 345 at r1 (raw file):

        let gas = (versioned_constants.l2_resource_gas_costs.gas_per_data_felt * total_data_size)
            .to_integer();
        // Does that make sense??

I am discussing this with Ilia.

Code quote:

/ Does that make sense??

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)

@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/txs_resources branch 4 times, most recently from 18c1d34 to 510e9e3 Compare August 15, 2024 11:43
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/txs_resources branch from 510e9e3 to bf7d8be Compare August 28, 2024 09:09
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from de14aaf to 37b7aaf Compare August 28, 2024 09:10
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/txs_resources branch from bf7d8be to ec3790b Compare August 28, 2024 13:21
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 37b7aaf to ff51985 Compare August 28, 2024 13:22
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/txs_resources branch from ec3790b to e823cfa Compare September 1, 2024 05:32
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from ff51985 to 9678b45 Compare September 1, 2024 05:32
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (nimrod/l2_gas/txs_resources@a8898b8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/blockifier/src/transaction/objects.rs 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##             nimrod/l2_gas/txs_resources     #460   +/-   ##
==============================================================
  Coverage                               ?   70.87%           
==============================================================
  Files                                  ?       85           
  Lines                                  ?    11023           
  Branches                               ?    11023           
==============================================================
  Hits                                   ?     7812           
  Misses                                 ?     2822           
  Partials                               ?      389           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/txs_resources branch from e823cfa to 3545a13 Compare September 1, 2024 06:00
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 9678b45 to 1c12f1d Compare September 1, 2024 06:00
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)

@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/txs_resources branch from 3545a13 to 7780737 Compare September 1, 2024 08:17
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 1c12f1d to 77925d7 Compare September 1, 2024 08:17
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/txs_resources branch from 7780737 to 9ddc2b9 Compare September 1, 2024 11:00
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 77925d7 to 014a7b6 Compare September 1, 2024 11:00
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/txs_resources branch from 9ddc2b9 to db47673 Compare September 3, 2024 06:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 014a7b6 to b90b768 Compare September 3, 2024 06:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/txs_resources branch from db47673 to 6324c9a Compare September 3, 2024 13:42
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from b90b768 to df18d94 Compare September 3, 2024 13:43
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/txs_resources branch from 6324c9a to 8b3d045 Compare September 3, 2024 13:46
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from df18d94 to b1a83bb Compare September 3, 2024 13:46
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/txs_resources branch from 8b3d045 to d5f495b Compare September 3, 2024 13:52
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from b1a83bb to 40c1736 Compare September 3, 2024 13:52
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/txs_resources branch from d5f495b to afeda2e Compare September 3, 2024 15:18
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 40c1736 to 8e17973 Compare September 3, 2024 15:18
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/txs_resources branch from afeda2e to 48335f4 Compare September 4, 2024 06:39
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 8e17973 to 605fcc5 Compare September 4, 2024 06:39
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/txs_resources branch from 48335f4 to 24f1748 Compare September 4, 2024 07:05
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 605fcc5 to 019b564 Compare September 4, 2024 07:05
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/txs_resources branch from 24f1748 to 49c16a8 Compare September 4, 2024 11:07
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 019b564 to 93b2535 Compare September 4, 2024 11:07
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/txs_resources branch from 49c16a8 to caf494f Compare September 4, 2024 11:10
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 93b2535 to f7fa5ae Compare September 4, 2024 11:10
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/txs_resources branch from caf494f to 7eaba87 Compare September 4, 2024 13:37
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from f7fa5ae to 8219d75 Compare September 4, 2024 13:38
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/txs_resources branch from 7eaba87 to 1d1c197 Compare September 5, 2024 07:18
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 8219d75 to b16ec40 Compare September 5, 2024 07:18
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/txs_resources branch from 1d1c197 to a8898b8 Compare September 5, 2024 11:09
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from b16ec40 to ea8a494 Compare September 5, 2024 11:10
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants