-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(fee): add calldata and signature l2 cost #460
build(fee): add calldata and signature l2 cost #460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @TzahiTaub)
crates/blockifier/src/transaction/objects.rs
line 345 at r1 (raw file):
let gas = (versioned_constants.l2_resource_gas_costs.gas_per_data_felt * total_data_size) .to_integer(); // Does that make sense??
I am discussing this with Ilia.
Code quote:
/ Does that make sense??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)
18c1d34
to
510e9e3
Compare
510e9e3
to
bf7d8be
Compare
de14aaf
to
37b7aaf
Compare
bf7d8be
to
ec3790b
Compare
37b7aaf
to
ff51985
Compare
ec3790b
to
e823cfa
Compare
ff51985
to
9678b45
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nimrod/l2_gas/txs_resources #460 +/- ##
==============================================================
Coverage ? 70.87%
==============================================================
Files ? 85
Lines ? 11023
Branches ? 11023
==============================================================
Hits ? 7812
Misses ? 2822
Partials ? 389 ☔ View full report in Codecov by Sentry. |
e823cfa
to
3545a13
Compare
9678b45
to
1c12f1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)
3545a13
to
7780737
Compare
1c12f1d
to
77925d7
Compare
7780737
to
9ddc2b9
Compare
77925d7
to
014a7b6
Compare
9ddc2b9
to
db47673
Compare
014a7b6
to
b90b768
Compare
db47673
to
6324c9a
Compare
b90b768
to
df18d94
Compare
6324c9a
to
8b3d045
Compare
df18d94
to
b1a83bb
Compare
8b3d045
to
d5f495b
Compare
b1a83bb
to
40c1736
Compare
d5f495b
to
afeda2e
Compare
40c1736
to
8e17973
Compare
afeda2e
to
48335f4
Compare
8e17973
to
605fcc5
Compare
48335f4
to
24f1748
Compare
605fcc5
to
019b564
Compare
24f1748
to
49c16a8
Compare
019b564
to
93b2535
Compare
49c16a8
to
caf494f
Compare
93b2535
to
f7fa5ae
Compare
caf494f
to
7eaba87
Compare
f7fa5ae
to
8219d75
Compare
7eaba87
to
1d1c197
Compare
8219d75
to
b16ec40
Compare
1d1c197
to
a8898b8
Compare
b16ec40
to
ea8a494
Compare
This change is