chore(native_blockifier): convert general config to os config

[amosStarkware]

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.40%. Comparing base (df672bc) to head (380a783).
Report is 5 commits behind head on main-v0.13.2.

Files	Patch %	Lines
crates/native_blockifier/src/py_block_executor.rs	71.42%	2 Missing ⚠️
crates/native_blockifier/src/py_validator.rs	0.00%	2 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           main-v0.13.2     #561      +/-   ##
================================================
- Coverage         76.41%   76.40%   -0.01%     
================================================
  Files               314      314              
  Lines             34241    34238       -3     
  Branches          34241    34238       -3     
================================================
- Hits              26164    26161       -3     
  Misses             5800     5800              
  Partials           2277     2277              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[amosStarkware]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion

---

crates/native_blockifier/src/py_block_executor.rs line 407 at r1 (raw file):

        path: std::path::PathBuf,
        max_state_diff_size: usize,
    ) -> Self {

Turns out this was passed to PyValidator & PyBlockExecutor, just never used.
validate_max_n_steps was also passed PyGeneralConfig and not used (but it was also passed by 'PyVersionedConstantsOverrides' and used. this duplication was not added by me, BTW)

Suggestion:

    pub invoke_tx_max_n_steps: u32

[amosStarkware]

+reviewer:@dorimedini-starkware +reviewer:@Yonatan-Starkware

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @Yonatan-Starkware)

[amosStarkware]

-reviewer:@Yonatan-Starkware +reviewer:@Yoni-Starkware

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @Yoni-Starkware)

[dorimedini-starkware]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @Yoni-Starkware)

---

crates/native_blockifier/src/py_block_executor.rs line 407 at r1 (raw file):

Previously, amosStarkware wrote…

Turns out this was passed to PyValidator & PyBlockExecutor, just never used.
validate_max_n_steps was also passed PyGeneralConfig and not used (but it was also passed by 'PyVersionedConstantsOverrides' and used. this duplication was not added by me, BTW)

I don't see these highlighted lines here, what are you referring to?

[amosStarkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @Yoni-Starkware)

---

crates/native_blockifier/src/py_block_executor.rs line 407 at r1 (raw file):

Previously, dorimedini-starkware wrote…

I don't see these highlighted lines here, what are you referring to?

to the fields PyGeneralConfig::invoke_tx_max_n_steps, PyGeneralConfig::validate_max_n_steps (which I deleted)

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)