chore: wrap cairo lang version id for code dedup

[ArniStarkware]

Pull Request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build-related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

There is code duplication between Cairo-Lang's version ID and the gateway's version ID.

What is the new behavior?

• Refactor the Gateway's version ID as a wrapper.

Does this introduce a breaking change?

• Yes
• No

Other information

---

This change is 

[ArniStarkware]

• chore: move safe_slice to shared utils #474
• chore: wrap cairo lang version id for code dedup #83 👈
• chore: use cairo lang util to extract sierra program version id #84
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite

[yair-starkware]

Why don't we use the type directly from Cairo?

[ArniStarkware]

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware and @yair-starkware)

a discussion (no related file):

Previously, yair-starkware (Yair) wrote…

Why don't we use the type directly from Cairo?

The issue is that Cairo-lang does not implement Serialize and Deserialize.
We define a wrapper that will have the required functionality.

---

---

crates/gateway/src/compiler_version.rs line 22 at r1 (raw file):

#[derive(Clone, Copy, Debug, PartialEq)]
pub struct VersionId(pub CairoLangVersionId);

@yair-starkware Your question is about this line.

The issue is that Cairo-lang does not implement Serialize and Deserialize.
We define a wrapper that will have the required functionality.

Code quote:

#[derive(Clone, Copy, Debug, PartialEq)]
pub struct VersionId(pub CairoLangVersionId);

[yair-starkware]

Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

[ArniStarkware]

crates/gateway/src/compiler_version.rs line 22 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

@yair-starkware Your question is about this line.

The issue is that Cairo-lang does not implement Serialize and Deserialize.
We define a wrapper that will have the required functionality.

+reviewer:@elintul

[ArniStarkware]

I reordered the PRs.
This PR deals with wrapping the CairoLangVersionId with our VersionId.

This struct offers additional functionality for serialization as this object is used for configuration.

[ArniStarkware]

Open a PR in compilers for them to implement serialization/deserialization on Version Id.

[ArniStarkware]

Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @elintul, @Yael-Starkware, and @yair-starkware)

a discussion (no related file):

Previously, ArniStarkware (Arnon Hod) wrote…

Open a PR in compilers for them to implement serialization/deserialization on Version Id.

Done.

---

[ArniStarkware]

crates/gateway/src/compiler_version.rs line 44 at r6 (raw file):

        let sierra_program_for_compiler = sierra_program_as_felts_to_big_uint_as_hex(
            safe_slice(&sierra_program, 0..6).map_err(|_| VersionIdError::InvalidVersion {
                message: format!("Sierra program is too short."),

@yair-starkware - You already said - we should remove the message from InvalidVersion.

Code quote:

            safe_slice(&sierra_program, 0..6).map_err(|_| VersionIdError::InvalidVersion {
                message: format!("Sierra program is too short."),

[yair-starkware]

crates/gateway/src/compiler_version.rs line 44 at r6 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

@yair-starkware - You already said - we should remove the message from InvalidVersion.

Not sure what you mean, but maybe the error should be: "Couldn't get version from the program - program too short (expecting at least 6 felts, got {}."

[yair-starkware]

Reviewed 2 of 5 files at r4, 1 of 2 files at r5, 1 of 3 files at r6, 2 of 2 files at r7, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArniStarkware, @elintul, and @Yael-Starkware)

---

crates/gateway/src/stateless_transaction_validator_test.rs line 34 at r7 (raw file):

    static MIN_SIERRA_VERSION: OnceLock<VersionId> = OnceLock::new();
    MIN_SIERRA_VERSION.get_or_init(|| VersionId::new(1, 1, 0))
}

Can you use LazyLock instead of OnceLock?
https://doc.rust-lang.org/stable/std/sync/struct.LazyLock.html

Code quote:

fn min_sierra_version() -> &'static VersionId {
    static MIN_SIERRA_VERSION: OnceLock<VersionId> = OnceLock::new();
    MIN_SIERRA_VERSION.get_or_init(|| VersionId::new(1, 1, 0))
}

---

crates/gateway/src/utils.rs line 168 at r7 (raw file):

// TODO(Arni): Move this to a more general location.
pub fn safe_slice<T, R>(slice: &[T], range: R) -> Result<&[T], ()>

Why not to use get?
https://doc.rust-lang.org/stable/std/primitive.slice.html#method.get

[ArniStarkware]

Reviewable status: 2 of 6 files reviewed, 2 unresolved discussions (waiting on @elintul, @Yael-Starkware, and @yair-starkware)

---

crates/gateway/src/compiler_version.rs line 44 at r6 (raw file):

Previously, yair-starkware (Yair) wrote…

Not sure what you mean, but maybe the error should be: "Couldn't get version from the program - program too short (expecting at least 6 felts, got {}."

I used ChatGPT for phrasing.
Done.

---

crates/gateway/src/stateless_transaction_validator_test.rs line 34 at r7 (raw file):

Previously, yair-starkware (Yair) wrote…

Can you use LazyLock instead of OnceLock?
https://doc.rust-lang.org/stable/std/sync/struct.LazyLock.html

The compiler tells me: error[E0658]: use of unstable library feature 'lazy_cell'.

---

crates/gateway/src/utils.rs line 168 at r7 (raw file):

Previously, yair-starkware (Yair) wrote…

Why not to use get?
https://doc.rust-lang.org/stable/std/primitive.slice.html#method.get

Done.

[yair-starkware]

Reviewed 5 of 5 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)