-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: derive serialize and deserialize for chain info #97
chore: derive serialize and deserialize for chain info #97
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ArniStarkware and the rest of your teammates on Graphite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @dafnamatsry)
crates/blockifier/src/context.rs
line 72 at r1 (raw file):
} #[derive(Clone, Debug, Deserialize, PartialEq, Serialize)]
Why it's needed?
Code quote:
PartialEq,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)
crates/blockifier/src/context.rs
line 72 at r1 (raw file):
Previously, MohammadNassar1 (mohammad-starkware) wrote…
Why it's needed?
The struct StatefulTransactionValidatorConfig
in the blockifier will use this struct in #99.
It is used for testing. This derive is not heavy, so there is no need to limit it for testing only.
b544021
to
8b24eca
Compare
Merge activity
|
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information
This change is