Update golangci-lint (#807)

.github/workflows/golangci-lint.yml

@@ -9,16 +9,14 @@ jobs:
     runs-on: ubuntu-22.04
 
     steps:
-      - name: Checkout
-        uses: actions/checkout@v3
-
-      - name: Install Go
-        uses: actions/setup-go@v3
+      # Silence embed linting error
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
         with:
           go-version: 1.22.x
-
+      - run: mkdir frontend/build && touch frontend/build/dummy
       - name: Run golangci-lint
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v6
         with:
           # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
           version: latest

.golangci.yml

@@ -1,5 +1,8 @@
 run:
   timeout: 3m
+  go: 1.22
+
+issues:
   skip-files:
     - "pkg/models/generated_.*.go$"
 
@@ -65,7 +68,5 @@ linters-settings:
         disabled: true
       - name: unreachable-code
       - name: redefines-builtin-id
-  staticcheck:
-    go: "1.20"
   exhaustive:
     default-signifies-exhaustive: true

main.go

@@ -13,8 +13,6 @@ import (
 	"github.com/stashapp/stash-box/pkg/user"
 )
 
-// nolint
-//
 //go:embed frontend/build
 var ui embed.FS
 

pkg/api/server.go

@@ -198,7 +198,7 @@ func Start(rfp RepoProvider, ui embed.FS) {
 
 		go func() {
 			printVersion()
-			logger.Infof("stash-box is running on HTTPS at https://" + address + "/")
+			logger.Infof("stash-box is running on HTTPS at https://%s/", address)
 			logger.Fatal(httpsServer.ListenAndServeTLS("", ""))
 		}()
 	} else {
@@ -209,7 +209,7 @@ func Start(rfp RepoProvider, ui embed.FS) {
 
 		go func() {
 			printVersion()
-			logger.Infof("stash-box is running on HTTP at http://" + address + "/")
+			logger.Infof("stash-box is running on HTTP at http://%s/", address)
 			logger.Fatal(server.ListenAndServe())
 		}()
 	}