Postgres support #5355
Postgres support #5355
Conversation
Fix insert return id
Fix blobs
Blob test fixes
pkg/sqlite/database_postgres.go
Outdated
| if disableForeignKeys { | ||
| _, err = conn.Exec("SET session_replication_role = replica;") | ||
|
|
||
| if err != nil { | ||
| return nil, fmt.Errorf("conn.Exec(): %w", err) | ||
| } | ||
| } | ||
| if !writable { | ||
| _, err = conn.Exec("SET default_transaction_read_only = ON;") | ||
|
|
||
| if err != nil { | ||
| return nil, fmt.Errorf("conn.Exec(): %w", err) | ||
| } | ||
| } |
There was a problem hiding this comment.
I would suggest not supporting "disable foreign key" and "read-only" in Postgres in the application layer.
They exist for SQLite because of limitations in the DB, such as some messiness with foreign keys. For connecting to Postgres as read-only, I'd strongly recommend that admins create a user with read-only permissions to the DB, rather than doing that in Stash
There was a problem hiding this comment.
I agree that this is ugly and should be removed.
But that would necessitate adding another connection string.
Im gonna have to think about it.
Or simply add "database_string_ro" 🤣
There was a problem hiding this comment.
If you absolutely need to tell Stash to make this RO, you could add a query stirng parameter to the connection string.
Something like ?readonly=1 to the URL... and then we remove it
There was a problem hiding this comment.
Im gonna let a reviewer weigh-in on this
Sort by nulls last fix for tests. UUID handler Switch strftime for native postgresql types Fix bug in performer studio filter
LIKE in SQLITE is case insensetive by default, where its SENSETIVE in postgres. Postgres has ILIKE which is insensitive, we should use that
Fix findExactDuplicateQuery for sqlite and pgsql use. Fix random sort for pgsql. Fix studioquery test by setting the id as a number (sqlite isnt strict, but pgsql is)
Its slightly more performant, and slightly prettier
…in postgresql. Postgres is stricter and doesnt allow excess args.
So we initialize the specific database type in PostInit, which also makes it unavailable to the manager.
Fix a bug where phash distance didnt work. Fix a bug where i wrongly wrote getDBLike in a string in captionCriterionHandler.
Hello, this is an attempt at implementing postgres support.
If you want to test this branch, you can add these changes to your config.yml:
In the ui setup you must set the database path as the connection string to use this.
Also if you want anonymise to work a backup path has to be set
There are alot of changes, highlights:
lastInsertId is a SQLite specific feature, other databases need you to specify "returning id". Which our version of SQLite supports, but goqu doesnt mark it as supported, so we update to a dev version.
Call regexp as a function, as postgresql doesnt support named operators.
Postgresql C/CGo extension to support missing functionality (basename, phash_distance, regexp):
https://github.com/NodudeWasTaken/stash_pge
https://github.com/NodudeWasTaken/stash_sqlite_to_pgsql
Some particularly egregious changes are:
This will be the admins responsibility
We should probably add a postgres test
PGSQL_TEST='postgresql://username:password@localhost/dbname_for_testing' go test -tags "sqlite_stat4 sqlite_math_functions integration" ./...Some particularly lackings are:
I added testmode which mitigated it a little, but it still happens sometimes.
But i fear that it may cause insertion issues, maybe, since the thing that updates it doesnt clamp the value, and it unlike sqlite actually returns an error on overflow.
To look at (help me):
You can use dbeaver for testing the database, its nice for browsing various databases like sqlite and postgresql.
To support disable foreign keys we do (if anybody knows a better way, let me know):
"SET session_replication_role = replica;"
which requires extra postgres user permissions, just a note.
This is mainly a request for comments, or help, mainly help finishing this.
Fixes #3892