Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add stateValues to typegen output #160

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

add stateValues to typegen output #160

wants to merge 7 commits into from

Conversation

brunocrosier
Copy link
Contributor

@changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: f842022

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brunocrosier brunocrosier mentioned this pull request Jun 8, 2022
Closed
@Andarist
Copy link
Member

I know that it has been a while since you have created this PR - but could you rebase this on top of the main branch and add snapshots tests for the getTypegenOutput (the test setup has been refactored in the meantime)? I'd like to see how the generated output looks like to decide if we should include this as part of the typegen types or not.

brunocrosier
brunocrosier commented Aug 20, 2022
View reviewed changes
packages/shared/src/getTransitionsFromNode.ts
...toStatePaths(pathToStateValue(node.path)).map((path) => path.join('.')),
];
}, [] as string[]);
const states = allStateNodes.reduce((arr: StateValue[], node) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use StateValue type

every other change in this file is just formatting

@brunocrosier
Copy link
Contributor Author

I know that it has been a while since you have created this PR - but could you rebase this on top of the main branch and add snapshots tests for the getTypegenOutput (the test setup has been refactored in the meantime)? I'd like to see how the generated output looks like to decide if we should include this as part of the typegen types or not.

Sorry I lost a bit of context on this since opening the PR but I hope these are the changes you requested 🙂

@Andarist
Copy link
Member

Yeah, this is what I had in mind - thank you 🙏 I'm gonna try to take a look at this soon

@Andarist Andarist mentioned this pull request Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunocrosier @Andarist