You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reviewing #256 I've noticed that this piece of code has some serious issues so I think that it's best to drop this entirely for the time being.
it's prompting for all properties - even if they are already defined. It's clashing with the events coming from the <NewEvent/> as those could already define the required props. Could this be fixed by conditionally prompting against missing values? Yeah, sure... but...
this doesn't actually use the schema at all - it just prompts for the given keys. This would fail for any non-string values. Given that fact, I believe that it's better to remove this code for now and revisit it with a more complete solution in the future.
this logic first clones the received event and then mutates the deep property (which has not been cloned with spread). So this might work... but it probably could be done in a more explicit way that would be easier to follow.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reviewing #256 I've noticed that this piece of code has some serious issues so I think that it's best to drop this entirely for the time being.
<NewEvent/>as those could already define the required props. Could this be fixed by conditionally prompting against missing values? Yeah, sure... but...