Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add workload labels to the podTemplate in the scan Job #83

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

bendikp
Copy link
Member

@bendikp bendikp commented Jan 17, 2023

#80 only added labels to the scan Job, this PR also adds workload labels to the scan Pod.

Related to #19

@bendikp bendikp changed the title feat: add workload info to the pod template in the scan Job feat: add workload info to the podTemplate in the scan Job Jan 17, 2023
@bendikp bendikp changed the title feat: add workload info to the podTemplate in the scan Job feat: add workload labels to the podTemplate in the scan Job Jan 17, 2023
@bendikp bendikp marked this pull request as ready for review January 17, 2023 12:15
@bendikp bendikp requested a review from a team as a code owner January 17, 2023 12:15
@bendikp bendikp force-pushed the add-labels-to-job-pod branch from 8aa2820 to 1e9db4f Compare January 17, 2023 14:41
Copy link
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erikgb erikgb changed the title feat: add workload labels to the podTemplate in the scan Job fix: add workload labels to the podTemplate in the scan Job Jan 17, 2023
@erikgb
Copy link
Member

erikgb commented Jan 17, 2023

I modified the title, since I think this is a fix to the feature added in #80.

@bendikp bendikp merged commit b4327fd into statnett:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants