refactor: migrate to kubebuilder v4 multigroup layout #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
erikgb
force-pushed
the
kubebuilder-v4
branch
from
a687cf3 to
591800f
Compare
erikgb
changed the title
erikgb
force-pushed
the
kubebuilder-v4
branch
from
103222e to
8260b2b
Compare
erikgb
force-pushed
the
kubebuilder-v4
branch
from
8260b2b to
42f431b
Compare
bendikp
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the project structure to kubebuilder v4 multigroup layout, which seems to be the recommended future-proof project layout. I've been following the migration guide, which seems to be close to a re-skaffold of the project, and that is the reason for some additional adjustments/fixes.
It seems like the improved Makefile targets for installing files into the bin directory now checks the version. At least this works for controller-gen. Not sure about kustomize, since I was unable to verify it working. And goimports does not provide a version command in the CLI. :-( This improvement might be useful when fixing #7.