Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bundle jar file in release #8

Merged
merged 7 commits into from
Oct 31, 2023
Merged

Conversation

sverrehu
Copy link
Contributor

@sverrehu sverrehu commented Oct 30, 2023

GitHub Maven repo is quite useless, as it requires credentials for downloading packages.
This PR will publish the jar file as a release artifact. Unfortunately, using a 3rd party action, as the official one from GitHub is no longer maintained (and refers to the one used here).

This is how the artifact will be available in the release, from my test project: https://github.com/sverrehu/actions-test/releases/tag/v0.0.9

@sverrehu sverrehu requested a review from a team as a code owner October 30, 2023 14:18
Copy link
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sverrehu sverrehu merged commit 08b5518 into statnett:main Oct 31, 2023
2 checks passed
@sverrehu sverrehu deleted the release-jar branch October 31, 2023 11:14
@statnett-bot statnett-bot bot mentioned this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants