fix(docs): fix zero linerate in docs #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* run test pipeline on python 3.12 * run deploy pipeline on python 3.12
gunnhildsp
reviewed
Apr 8, 2024
pyproject.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [tool.poetry] | |||
| name = "linerate" | |||
| version = "1.0.0" | |||
| version = "1.0.1" | |||
There was a problem hiding this comment.
I think we should use 2.0.0 since we are implementing a breaking change
There was a problem hiding this comment.
It was already increased a major version (from 0.0.7) in a previous PR, which will also be part of this release. Reflecting on that, 1.0.0 would make more sense than 1.0.1.
This reverts commit 14ddc95.
gunnhildsp
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix zero-linerate in example used in docs. Required to generate docs without exceptions
update test and deploy pipelines to include and use latest python (v3.12)