Update thermal_model.py #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the function compute_conductor_temperature. Stop dividing the temperature, and divide the current passed to the solver instead.
|
Could you write a test as well, to ensure that the bug does not appear again later? Maybe a test that checks that if temperature with current X and 1 conductor is T, then temperature with current 2*X and 2 conductors should also be T. |
halvorlu
reviewed
Nov 28, 2024
halvorlu
reviewed
Nov 28, 2024
…current will be divided by the number of conductors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the function compute_conductor_temperature. Stop dividing the temperature, and divide the current passed to the solver instead.