Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add infrastructure to select fork choice version #5387

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

etan-status
Copy link
Contributor

To allow testing ethereum/consensus-specs#3466 add support for selecting fork choice version at launch. This means we can deploy a different logic when DENEB_FORK_EPOCH != FAR_FUTURE_EPOCH that won't be used on Mainnet.

To allow testing ethereum/consensus-specs#3466
add support for selecting fork choice version at launch. This means we
can deploy a different logic when `DENEB_FORK_EPOCH != FAR_FUTURE_EPOCH`
that won't be used on Mainnet.
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Unit Test Results

         9 files  ±0    1 089 suites  ±0   38m 47s ⏱️ + 1m 44s
  3 845 tests ±0    3 566 ✔️ ±0  279 💤 ±0  0 ±0 
15 886 runs  ±0  15 581 ✔️ ±0  305 💤 ±0  0 ±0 

Results for commit 576a9a6. ± Comparison against base commit afb5fda.

♻️ This comment has been updated with latest results.

@etan-status
Copy link
Contributor Author

Also adds

  "extra_data": {
    "version": "stable"
  }

to http://127.0.0.1:5052/eth/v1/debug/fork_choice so that explorer tools can distinguish selected version

extra_data is an implementation-specific dictionary.

@etan-status etan-status merged commit 8fa5580 into unstable Sep 12, 2023
9 checks passed
@etan-status etan-status deleted the dev/etan/fc-prefilter branch September 12, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants