Synchronously check all transactions to have non-zero length
#6491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reject blocks with zero length transactions early when no EL connected. - ethereum/consensus-specs#3885
tersec
reviewed
Aug 16, 2024
| # whatever data the block itself contains. | ||
| # required checks on the CL instead and proceed as if the EL was syncing | ||
| # https://github.com/ethereum/consensus-specs/blob/v1.5.0-alpha.4/specs/bellatrix/beacon-chain.md#verify_and_notify_new_payload | ||
| # https://github.com/ethereum/consensus-specs/blob/1.5.0-alpha.4/specs/deneb/beacon-chain.md#modified-verify_and_notify_new_payload |
There was a problem hiding this comment.
these two lines refer to the spec version differently, with/without v prefix?
There was a problem hiding this comment.
thanks, have fixed it. the v prefix is correct.
etan-status
commented
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reject blocks with zero length transactions early when no EL connected.
transactionsto have non-zero length ethereum/consensus-specs#3885