Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add column support to beacon chain db #6660

Open
wants to merge 6 commits into
base: unstable
Choose a base branch
from
Open

add column support to beacon chain db #6660

wants to merge 6 commits into from

Conversation

agnxsh
Copy link
Contributor

@agnxsh agnxsh commented Oct 20, 2024

No description provided.

Copy link

github-actions bot commented Oct 20, 2024

Unit Test Results

       12 files  ±0    1 814 suites  ±0   54m 46s ⏱️ - 1m 29s
  5 238 tests +1    4 890 ✔️ +1  348 💤 ±0  0 ±0 
29 101 runs  +4  28 649 ✔️ +4  452 💤 ±0  0 ±0 

Results for commit 885211d. ± Comparison against base commit a157760.

♻️ This comment has been updated with latest results.

@tersec
Copy link
Contributor

tersec commented Oct 23, 2024

My concern is that PeerDAS won't, in fact, be in PectrA/Pectra, and as such this will trigger for end-users when the first of Sepolia or Holesky forks. Want to keep this out of unstable until that's resolved. One way of doing this is to create new Fulu fork in the codebase and merge fork-specific PeerDAS code into that, which presumably is where it will ship, and if not, can rename/move later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants