fix: wrong semverCompare usage in helm chart

steadybit · Sep 11, 2024 · 384bfc0 · 384bfc0
1 parent 3f79664
commit 384bfc0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/charts/steadybit-extension-host/Chart.yaml b/charts/steadybit-extension-host/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v2
 name: steadybit-extension-host
 description: Steadybit host extension Helm chart for Kubernetes.
-version: 1.1.20
+version: 1.1.21
 appVersion: v1.2.21
 home: https://www.steadybit.com/
 icon: https://steadybit-website-assets.s3.amazonaws.com/logo-symbol-transparent.png

diff --git a/charts/steadybit-extension-host/templates/daemonset.yaml b/charts/steadybit-extension-host/templates/daemonset.yaml
@@ -32,7 +32,7 @@ spec:
         {{- toYaml . | nindent 8 }}
         {{- end }}
       annotations:
-        {{- if semverCompare "<1.30" .Capabilities.KubeVersion.Version}}
+        {{- if semverCompare "<1.30-0" .Capabilities.KubeVersion.Version}}
         "container.apparmor.security.beta.kubernetes.io/{{ include "extensionlib.names.name" . }}": unconfined
         {{- end }}
         {{- include "extensionlib.annotation" (list . .Values.containerPorts.http (list "ACTION" "DISCOVERY") ) | nindent 8 }}
@@ -111,7 +111,7 @@ spec:
               path: /health/readiness
               port: {{ .Values.containerPorts.health }}
           securityContext:
-            {{- if semverCompare ">=1.30" .Capabilities.KubeVersion.Version}}
+            {{- if semverCompare ">=1.30-0" .Capabilities.KubeVersion.Version}}
             appArmorProfile:
               type: Unconfined
             {{- end }}

diff --git a/charts/steadybit-extension-host/tests/daemonset_test.yaml b/charts/steadybit-extension-host/tests/daemonset_test.yaml
@@ -12,7 +12,7 @@ tests:
   - it: manifest should match snapshot with appArmorProfile for k8s >= 1.30
     capabilities:
       majorVersion: 1
-      minorVersion: 30
+      minorVersion: 30.3-gke.1639000
     asserts:
       - matchSnapshot: { }
   - it: manifest should match snapshot using podAnnotations, podLabels and resources