Upgrade from ocaml-migrate-parsetree to Ppxlib #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocaml-migrate-parsetree is now deprecated. This upgrades the code to use Ppxlib. Remaining work to do: handle locations correctly so that tools like Merlin are not buggy on code that uses the PPX.
|
(In case that wasn’t clear, this version is strictly better than master since locations are not emitted properly on master either.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ocaml-migrate-parsetree is now deprecated. This upgrades the code to use Ppxlib, so that ppx_stage can be used on recent OCaml versions.
With these changes, the code now compiles and passes the tests in OCaml 5.1.1.
Future work: handle locations correctly so that tools like Merlin are not buggy on code that uses the PPX.