WIP: Adding reserve() and capability() feature likes std::vector<> #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since our minimal requirement is c++14, we have the helper type std::enable_if_t. Signed-off-by: Randy Li <ayaka@soulik.info>
hizukiayaka
commented
Jun 27, 2024
src/recycle/shared_pool.hpp
Outdated
|
|
||
| constexpr void reserve (std::size_t new_cap) | ||
| { | ||
| std::list<value_ptr> pending_resources; |
There was a problem hiding this comment.
I think I could use std::deque<> here, since we don't need to any random access.
| } | ||
|
|
||
| m_max_capacity = new_cap; | ||
| } |
There was a problem hiding this comment.
It would have a critical section here. The return of capacity() and unused_free() won't match.
Besides, while we recycle buffer here, the second thread which calls the pool->allocate() may break the atomic.
Should I use the thread-local lock here, we need make a rule which thread calls reserve(), which thread can allocate().
We can pre-allocate the need elements. Signed-off-by: Randy Li <ayaka@soulik.info>
Signed-off-by: Randy Li <ayaka@soulik.info>
hizukiayaka
force-pushed
the
pr_reserve_space
branch
from
71d4c2e to
320cfa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MR for #22