fix(init): don't gitignore triple-dash #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethengelman
approved these changes
Apr 25, 2024
chadoh
force-pushed
the
fix/init/gitignore-delimiter
branch
from
7e841a8 to
ff23a0d
Compare
The `---` is only for the `README.md` file, not `gitignore`. I've also switched the "(ab)used link label (for use with reference style links)"-style comment (`[//] #`) for an HTML comment (`<!-- ... -->`). This means it will be rendered in the HTML, which might be preferable, and is at a minimum benign. I hadn't been familiar with the `[//]: #`-style comment until I saw it here (and searched to find a description of it, along with the "(ab)use" line above, [here]), and I don't think it's worth the potential confusion for users of `soroban contract init`. [here]: https://stackoverflow.com/a/20885980/249801
chadoh
force-pushed
the
fix/init/gitignore-delimiter
branch
from
ff23a0d to
2002fa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
---is only for theREADME.mdfile, notgitignore.I've also switched the "(ab)used link label (for use with reference
style links)"-style comment (
[//] #) for an HTML comment (<!-- ... -->). This means it will be rendered in the HTML, which might bepreferable, and is at a minimum benign. I hadn't been familiar with the
[//]: #-style comment until I saw it here (and searched to find adescription of it, along with the "(ab)use" line above, here), and I
don't think it's worth the potential confusion for users of
soroban contract init.