Render Stellar Events as JSON Instead of Rust Debug Forma #1659
+10
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leighmcculloch I wrote a not right command and closed my PR🥲, this is a new one with the changes that you requested🫡🫶🏻 |
|
ready to review |
|
@willemneal let me know what you think please |
|
@juandiegocv27 could you look into the tests |
| ); | ||
| } | ||
| OutputFormat::Plain => println!("{event}"), | ||
| OutputFormat::Pretty => event.pretty_print()?, |
There was a problem hiding this comment.
The hope of the issue was to address that "Events in pretty print mode print as Rust debug format," and same in the plain mode too I think. The intent is to fix that, rather than return only JSON. So each topic and the value should print as JSON, but the rest of the format should stay the same.
See:
There was a problem hiding this comment.
ok sure, thank you for letting me know, i'll fix that as soon as possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR modifies the Stellar events output to render as JSON instead of using the Rust debug format. Additionally, it updates the path in
boilerplate.rsfor including the WASM file.Why
The change is being made because developers are more familiar with the JSON format, which provides a standardized way of viewing event data. It aligns with Render events as json in stellar events pretty output instead of as rust debug issue, aiming to improve the readability and usability of the event logs for developers.