Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake for nixpkgs on darwin #1665

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

TomMD
Copy link
Contributor

@TomMD TomMD commented Oct 9, 2024

Three issues addressed.

  1. On darwin we need SystemConfig as a native build input.
  2. Darwin doesn't have libudev-zero
  3. Most darwin users will have the default zsh shell. When invoking nix develop they'll get a bash shell. The shell script setting up autocompletion of commands needs to not use the SHELL variable because that will be zsh and not the correct value of bash. See below for nix develop with this PR (without this PR the first result is zsh and thus the completion script fails).
$ echo $shell
bash
$ echo $SHELL
/bin/zsh
$ echo $0
bash

@leighmcculloch leighmcculloch requested a review from Ifropc October 9, 2024 07:31
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I defer to @Ifropc that knows more about flakes and nix than I do, but there is one thing being removed as part of this PR that I think is unrelated, but good. And there are two other things I think we should also remove.

It would be ideal if we could remove those unrelated three things in a separate PR though.

flake.nix Outdated Show resolved Hide resolved
flake.nix Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
@Ifropc Ifropc linked an issue Oct 9, 2024 that may be closed by this pull request
Copy link
Contributor

@Ifropc Ifropc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @TomMD

@Ifropc Ifropc enabled auto-merge (squash) October 9, 2024 20:48
@Ifropc Ifropc merged commit 440b75d into stellar:main Oct 9, 2024
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Flake does not build cli on Darwin
3 participants