Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Several small fixes to tests:
Why
The contract imports both the token sdk and the sdk at different versions. Because the token sdk depends on a specific version of the sdk two sdk's end up being imported into the contract. Two sdk's cannot be imported into the same contract because they both provide a panic_impl and rust only allows one to be linked.
This test failure was somehow accidentally introduced in:
In the other cases those other bugs have been merged while the tests were broken by the first thing. They weren't discovered till now because with the tests build broken the compiler was not pointing us at them.
The help test run was moved because it's so far it causes a complete job to occur before the test job gets a change to have its one be identified as a dependency. We haven't seen this same thing on other repos with multiple complete jobs, so not sure if this is new behaviour for GHA, or just something to do with timing on this repo. In either case, we have other generated checks in the main workflow and it doesn't hurt to put it there.
The help job got simplified because it was using github scripts, and github outputs, when we have a simpler pattern for doing that type of diff check already in this repo.