feat(ts-bindings): Client.deploy with constructor args #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadoh
force-pushed
the
feat/ts-bindings/constructor-args
branch
5 times, most recently
from
5bc1b9d to
61a99d7
Compare
willemneal
reviewed
Nov 20, 2024
cmd/crates/soroban-spec-typescript/fixtures/test_custom_types/src/index.ts
Outdated
Show resolved
Hide resolved
chadoh
force-pushed
the
feat/ts-bindings/constructor-args
branch
3 times, most recently
from
bb00731 to
e924f39
Compare
- allow omiting `--contract-id` flag to `stellar contract bindings typescript` command, passing only `--wasm` instead - if no `--contract-id` is included, then the contract will not be fetched from a network, so no network information is logged in this case - this means it's possible to create TS Bindings libraries for contracts that have not yet been deployed, which makes it useful to add types for `Client.deploy` to the generated TS Bindings - add fixture example of `test_constructor` from test-wasms
chadoh
force-pushed
the
feat/ts-bindings/constructor-args
branch
from
e924f39 to
7c29f05
Compare
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/typescript@5.6.3 |
Ifropc
reviewed
Dec 3, 2024
Shaptic
reviewed
Dec 3, 2024
2 tasks
kalepail
approved these changes
Dec 6, 2024
willemneal
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
--contract-idflag tostellar contract bindings typescriptcommand, passing only--wasminstead--contract-idis included, then the contract will not befetched from a network, so no network information is logged in this
case
that have not yet been deployed, which makes it useful to add types
for
Client.deployto the generated TS Bindingstest_constructorfrom test-wasmsWhy
Fixes #1562
Known limitations
stellar contract bindings typescriptshould probably also support--wasm-hash. I will do this in a follow-up PR.