Add test for remapping paths #1786
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
approved these changes
Dec 20, 2024
Comment on lines
+194
to
+200
| #[derive(Eq, PartialEq, Copy, Clone)] | ||
| enum Remap { | ||
| Yes, | ||
| No, | ||
| } | ||
|
|
||
| fn run(contract_name: &str, manifest_path: &std::path::Path, remap: Remap) -> bool { |
|
@brson Thanks for following up with this test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1704
What
Adds a test case that absolute paths embedded in the wasm by rustc are remapped to relative paths, as implemented previously in #1594
Why
Previously implemented feature needs tests.
Known limitations
This will have a minor merge conflict with #1736
This adds the
eth_abiexample as a test fixture. It is the project I use to test the remapping feature. Not all soroban projects exhibit the problem of embedding absolute paths; this test is implemented such that it both confirms that eth_abi exhibits the problem, and stellar-cli fixes it.