contract init: generate a contract that's compatible with fuzzing #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
changed the title
Ifropc
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Generate contracts with their crate-type set to both
libandcdylib.Why
cdylibis required for building to a wasm file, andlibis required to be able to import the crate into another crate.To do fuzzing the contract has to be imported into another binary.
Contract init should generate a contract that's compatible with fuzzing.
Historically the
libhas been left off because specifying multiplecrate-types results in link time optimisation (LTO) not running and the final wasm builds being larger. However since then the stellar-cli now provides a build command that runs the cargo tooling with configurations to ensure onlycdylibis enabled when the wasm build occurs. So there's no longer a need to avoid the multiple crate-type.All contracts should be fuzzing and have both crate types.
Close #1800