Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial draft cap 63 #1587

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Initial draft cap 63 #1587

merged 2 commits into from
Jan 14, 2025

Conversation

SirTyson
Copy link
Contributor

This is the initial draft CAP for in-memory Soroban state and automatic entry restoration via InvokeHostFunctionOp. It depends on partial state archival from CAP-0062, but not full state archival of CAP-0057.

Copy link
Contributor

@dmkozh dmkozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked through the full CAP yet (and the semantics probably can be discussed separately), but I have some issues with the XDR that probably are easier to resolve now.

core/cap-0063.md Outdated Show resolved Hide resolved
core/cap-0063.md Outdated Show resolved Hide resolved
core/cap-0063.md Outdated Show resolved Hide resolved
core/cap-0063.md Outdated Show resolved Hide resolved
core/cap-0063.md Outdated Show resolved Hide resolved
core/cap-0063.md Outdated Show resolved Hide resolved
core/cap-0063.md Outdated Show resolved Hide resolved
core/cap-0063.md Outdated Show resolved Hide resolved
core/cap-0063.md Outdated Show resolved Hide resolved
core/cap-0063.md Outdated Show resolved Hide resolved
core/cap-0063.md Outdated Show resolved Hide resolved
core/cap-0063.md Outdated Show resolved Hide resolved
core/cap-0063.md Outdated Show resolved Hide resolved
core/cap-0063.md Outdated Show resolved Hide resolved
core/cap-0063.md Outdated Show resolved Hide resolved
core/cap-0063.md Outdated Show resolved Hide resolved
core/cap-0063.md Outdated Show resolved Hide resolved
core/cap-0063.md Outdated Show resolved Hide resolved
core/cap-0063.md Outdated Show resolved Hide resolved
core/cap-0063.md Outdated Show resolved Hide resolved
@MonsieurNicolas
Copy link
Contributor

CAP needs to be renumbered. Please avoid discussions in PRs and prefer discussions to make it easier to retroactively understand points that were debated

@SirTyson
Copy link
Contributor Author

Addressed some of the comments, but let's merge this and move this over to discussion per Nico.

dmkozh
dmkozh previously approved these changes Jan 14, 2025
@SirTyson SirTyson enabled auto-merge (squash) January 14, 2025 21:41
@SirTyson SirTyson merged commit bb1c8d7 into master Jan 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants