audit/KAD-3309

[gilbert-hernandez]

🎫 #[Jira Ticket]
https://stellarwp.atlassian.net/browse/KAD-3309
https://stellarwp.atlassian.net/browse/KAD-3337
...

Issue Info

• Were you able to reproduce the issue?
• Is the issue from the ticket solved? (If not, why?)

Checklist

• I have performed a self-review.
• No unrelated files are modified.
• No debugging statements exist (Ex: console.log, error_log).
• There are no warnings or notices in the wordpress error log.
• Passes all tests (linting, acceptance, & unit)

Block specific checklist (where relevant)

• Tested with an existing instance of this block .
• Tested creating a new instance of this block.
• Tested with Dynamic content & Elements.

Are there dependent changes in another repository?

• No.
• Yes. Please provide the link to the PR.

[oakesjosh]

A couple comments, but it's looking good!

[oakesjosh]

We'll want to compare the currently set values to the default values

For example isEqual( tabletValue, defaultTablet )

[oakesjosh]

We'll want to compare the currently set values to the default values

[oakesjosh]

In some blocks we import the block.json to access the attributes ( Ex: import metadata from './block.json';)

We should do that here and we can pass the actual default values. Like metadata.attriubtes.topSepHeightTab. If we ever change the default values we don't have to update all the references.

[gilbert-hernandez]

I updated the disabled logic for the components, I imported and used metadata for the divider height and widths, and I updated the block.json attributes for the divider width/height default values.

[gilbert-hernandez]

I removed the default values I added to the block.json file. I tested it and they are not necessary. I also corrected the default value used for the divider height/width components.