Add license key to auth button

[tarecord]

When a site needs to connect to the licensing server to generate a token or connect securely with an external service, a license key should be passed with the request. This attaches the license key to the auth button and adjusts a little of the functionality to make the UX more fluid for the user.

This also fixes some styling of the button so that it displays to the right of the license field that is used for authentication.

No License Key Present

License Key Invalid

License Key Valid

Site Connected

[borkweb]

I'm curious why this is being removed? Was the test passing before? Did something change to actually not require those query args? Were they useless before and this is cleanup?

[tarecord]

Yep, they were unnecessary when the test was first added. Those values are combined and encoded for the uplink_callback parameter here in Auth_Url_Builder::build():

uplink/src/Uplink/Auth/Auth_Url_Builder.php

Lines 59 to 80 in 11b5e6d

	// Query arguments to combine with $_GET and add to the authorization URL.
	$args = [
	'uplink_domain' => $domain,
	'uplink_slug' => $slug,
	];
	// Optionally include a license key if set.
	if ( ! empty( $this->license_key ) ) {
	$args['uplink_license'] = $this->license_key;
	}
	$url = add_query_arg(
	array_filter( array_merge( $_GET, $args ) ),
	admin_url( $pagenow )
	);
	return sprintf( '%s?%s',
	$auth_url,
	http_build_query( [
	'uplink_callback' => base64_encode( $this->nonce->create_url( $url ) ),
	] )
	);

[tarecord]

I had to update this because of the new data attribute, so I made some changes there too.

[borkweb]

This all looks fantastic! 👯