Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust to v1.83.0 #499

Merged
merged 1 commit into from
Nov 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ jobs:
# https://github.com/rust-lang/rustup/issues/2441
#
# for more information.
rustup toolchain install 1.81.0 --no-self-update # [ref:rust_1.81.0]
rustup default 1.81.0 # [ref:rust_1.81.0]
rustup toolchain install 1.83.0 --no-self-update # [ref:rust_1.83.0]
rustup default 1.83.0 # [ref:rust_1.83.0]

# Add the targets.
rustup target add x86_64-pc-windows-msvc
Expand Down Expand Up @@ -131,8 +131,8 @@ jobs:
set -euxo pipefail

# Install the appropriate version of Rust.
rustup toolchain install 1.81.0 # [ref:rust_1.81.0]
rustup default 1.81.0 # [ref:rust_1.81.0]
rustup toolchain install 1.83.0 # [ref:rust_1.83.0]
rustup default 1.83.0 # [ref:rust_1.83.0]

# Add the targets.
rustup target add x86_64-apple-darwin
Expand Down Expand Up @@ -205,8 +205,8 @@ jobs:
set -euxo pipefail

# Install the appropriate version of Rust.
rustup toolchain install 1.81.0 # [ref:rust_1.81.0]
rustup default 1.81.0 # [ref:rust_1.81.0]
rustup toolchain install 1.83.0 # [ref:rust_1.83.0]
rustup default 1.83.0 # [ref:rust_1.83.0]

# Fetch the program version.
VERSION="$(cargo pkgid | cut -d# -f2 | cut -d: -f2)"
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added
- Typical now requires field index gaps to be marked as deleted.

## [0.9.7] - 2024-09-06
## [0.9.7] - 2024-11-28

### Changed
- Some redundant conversions are no longer emitted by the Rust code generator.
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,7 @@ Notice that several types can take advantage of a more compact representation wh

## Benchmarks

We have coarse-grained benchmarks [here](https://github.com/stepchowfun/typical/tree/main/benchmarks) for each code generator. The data below were averaged over 3 runs on a 2023 MacBook Pro with the Apple M2 Max chip and 32 GiB of RAM. The Rust benchmark was compiled by Rust 1.81.0 with `--release`. The TypeScript benchmark was transpiled to JavaScript by TypeScript 4.5.5 and run with Node.js 18.17.0.
We have coarse-grained benchmarks [here](https://github.com/stepchowfun/typical/tree/main/benchmarks) for each code generator. The data below were averaged over 3 runs on a 2023 MacBook Pro with the Apple M2 Max chip and 32 GiB of RAM. The Rust benchmark was compiled by Rust 1.83.0 with `--release`. The TypeScript benchmark was transpiled to JavaScript by TypeScript 4.5.5 and run with Node.js 18.17.0.

One benchmark serializes and deserializes a large message containing several hundred megabytes of text:

Expand Down
2 changes: 1 addition & 1 deletion src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ impl fmt::Display for Error {
}

impl error::Error for Error {
fn source<'a>(&'a self) -> Option<&(dyn error::Error + 'static)> {
fn source<'a>(&'a self) -> Option<&'a (dyn error::Error + 'static)> {
self.reason.as_deref()
}
}
Expand Down
12 changes: 6 additions & 6 deletions toast.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ command_prefix: |
cargo-offline () { cargo --frozen --offline "$@"; }

# Use this wrapper for formatting code or checking that code is formatted. We use a nightly Rust
# version for the `trailing_comma` formatting option [tag:rust_fmt_nightly_2024-09-06]. The
# version for the `trailing_comma` formatting option [tag:rust_fmt_nightly_2024-11-28]. The
# nightly version was chosen as the latest available release with all components present
# according to this page:
# https://rust-lang.github.io/rustup-components-history/x86_64-unknown-linux-gnu.html
cargo-fmt () { cargo +nightly-2024-09-06 --frozen --offline fmt --all -- "$@"; }
cargo-fmt () { cargo +nightly-2024-11-28 --frozen --offline fmt --all -- "$@"; }

# Load the NVM startup file, if it exists.
if [ -f "$HOME/.nvm/nvm.sh" ]; then
Expand Down Expand Up @@ -75,18 +75,18 @@ tasks:
- install_packages
- create_user
command: |
# Install stable Rust [tag:rust_1.81.0].
# Install stable Rust [tag:rust_1.83.0].
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- \
-y \
--default-toolchain 1.81.0 \
--default-toolchain 1.83.0 \
--profile minimal \
--component clippy

# Add Rust tools to `$PATH`.
. "$HOME/.cargo/env"

# Install nightly Rust [ref:rust_fmt_nightly_2024-09-06].
rustup toolchain install nightly-2024-09-06 --profile minimal --component rustfmt
# Install nightly Rust [ref:rust_fmt_nightly_2024-11-28].
rustup toolchain install nightly-2024-11-28 --profile minimal --component rustfmt

install_node:
description: Install Node.js, a JavaScript runtime environment.
Expand Down