Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve icons #283

Closed
wants to merge 1 commit into from
Closed

improve icons #283

wants to merge 1 commit into from

Conversation

norflin321
Copy link

No description provided.

Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why you're making these changes and how you think they are better? On my terminal at least (kitty), it looks like most of the icons are the same, but more left-aligned instead of center-aligned. I actually prefer them to be more center-aligned because most of the other icons are center-aligned and it keeps them consistent.

@norflin321
Copy link
Author

Hello, original icons seem surprisingly small to me, new icons looks much bigger on my setup (macOS Ventura, kitty, nvim 0.10). I took them from another plugin that I use https://github.com/SmiteshP/nvim-gps/blob/master/lua/nvim-gps/init.lua.

Screenshot 2023-07-31 at 2 42 00 AM Screenshot 2023-07-31 at 2 42 52 AM

@stevearc
Copy link
Owner

Those icons are deprecated. If you search for the code points on https://www.nerdfonts.com/cheat-sheet you'll see that the ones you're adding are marked as "removed". For more information see ryanoasis/nerd-fonts#1190 (comment)

I'm not sure why the existing icons aren't rendering properly for you; kitty should be the same even across operating systems

@stevearc stevearc closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants