Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add trailing slash on yank_entry #504

Merged
merged 2 commits into from
Oct 28, 2024
Merged

feat: add trailing slash on yank_entry #504

merged 2 commits into from
Oct 28, 2024

Conversation

Foo-x
Copy link
Contributor

@Foo-x Foo-x commented Oct 28, 2024

Changed to add a trailing slash if the entry type is directory on yank_entry.

Closes #503

stevearc
stevearc requested changes Oct 28, 2024
View reviewed changes
Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sending back to you for lint

@Foo-x
Copy link
Contributor Author

Foo-x commented Oct 28, 2024

Fixed it according to the error message.

@stevearc
Copy link
Owner

Thanks for the PR!

@stevearc stevearc merged commit 42333bb into stevearc:master Oct 28, 2024
9 checks passed
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
Merged
@Foo-x Foo-x deleted the trailing-slash-on-yank_entry branch October 29, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevearc stevearc Awaiting requested review from stevearc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request: Add a trailing slash if the entry type is directory on yank_entry
2 participants
@Foo-x @stevearc