Adds current_active_session helper, memoization for current_user #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes stevepolitodesign#93, "Why is the ||= removed? current_user method". This adds memoization back to current_user / Current.user, plus causes log out when the current session is destroyed.
| forget_active_session | ||
| active_session.destroy |
There was a problem hiding this comment.
Could we still call active_session.destroy before the if statement? I only ask because we're calling it in both branches.
There was a problem hiding this comment.
That bothered me as it doesn't feel DRY, but there's no good way to handle it. "current_active_session" will certainly be memoized by the time "destroy" is called because of "authenticate_user!". But "current_active_session" has code to do a lookup for the comparison, and destroying it before then creates a dependency on "authenticate_user!" being called first.
So, yes, we can call it before the "if" statement, but I prefer everything to be explicit at the expense of an extra line. This might save a headache later during refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93, "Why is the ||= removed? current_user method". This adds memoization back to current_user / Current.user, plus causes log out when the current session is destroyed.
With this change, it's easy to find the current session and check its id against the param. The user is logged out if the current session is destroyed, allowing the tests to pass with memoization in place.