-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: tests #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CI test isn't working as expected - https://github.com/stjudecloud/workflows/blob/main/.github/workflows/lint-check.yaml#L43 It should be failing because I'm currently using a |
adthrasher
approved these changes
Nov 26, 2024
Last 3 commits broke the CI in an expected way. We should consider the CI green. Here's why:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of lines/files changed here but nothing huge. Most of the changes are related to changing names/paths for our test files to be a little clearer in their contents. There's still some room for improvement there.
I've also added a
tests/workflows/input_json/
directory with some files that aren't hooked up to anything yet.Includes some minor bug patches. Perhaps controversial, I changed our a longstanding convention for our
star_db
files. These are now expected to be "flat archives" (without a root directory). This makes us robust to the annoying case where the tar archive's filename doesn't match the inner contents.