Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: tests #187

Merged
merged 26 commits into from
Nov 26, 2024
Merged

ci: tests #187

merged 26 commits into from
Nov 26, 2024

Conversation

a-frantz
Copy link
Member

@a-frantz a-frantz commented Nov 25, 2024

Lots of lines/files changed here but nothing huge. Most of the changes are related to changing names/paths for our test files to be a little clearer in their contents. There's still some room for improvement there.

I've also added a tests/workflows/input_json/ directory with some files that aren't hooked up to anything yet.

Includes some minor bug patches. Perhaps controversial, I changed our a longstanding convention for our star_db files. These are now expected to be "flat archives" (without a root directory). This makes us robust to the annoying case where the tar archive's filename doesn't match the inner contents.

@a-frantz a-frantz self-assigned this Nov 25, 2024
@a-frantz
Copy link
Member Author

This CI test isn't working as expected - https://github.com/stjudecloud/workflows/blob/main/.github/workflows/lint-check.yaml#L43

It should be failing because I'm currently using a branch-tests tag but it is passing. Will take a look tomorrow.

@a-frantz a-frantz marked this pull request as ready for review November 26, 2024 15:23
@a-frantz
Copy link
Member Author

Last 3 commits broke the CI in an expected way. We should consider the CI green. Here's why:

  • Update lint-check.yaml fixed the broken lint-check CI and it started catching the usage of branch-* images (and OOD util images 😬 )
  • fix: bump to latest util image fixed the OOD util images, but the branch-* tags were still in use so that continued to fail
  • chore: don't use branch image fixed the lint-check CI but now the STAR tests are failing, as they are trying to pull an image which doesn't exist (and won't exist until this merges into main)

@a-frantz a-frantz merged commit 43462b0 into main Nov 26, 2024
12 of 34 checks passed
@a-frantz a-frantz deleted the ci/tests branch November 26, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants