Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team owners can permanently merge players #118

Open
sussexrick opened this issue Feb 3, 2020 · 0 comments
Open

Team owners can permanently merge players #118

sussexrick opened this issue Feb 3, 2020 · 0 comments
Assignees

Comments

@sussexrick
Copy link
Member

sussexrick commented Feb 3, 2020

Old interface was: if rename matches an existing player name, offer the choice to merge or to pick a new name. Hide the name box until its radio button is chosen.

Merging should be possible without going via the rename route, since that's not obvious, but if both exist they should post to the same place.

UX extends 'Edit player' as amended by #627. It adds a 'Permanently merge players' with 'Pick the name to use for the merged player'.

Player identities can only be merged permanently if they belong to the same team.

Merging code is in player-manager.class.php MergePlayers() method. Merge could work by linking two player identities somehow, which would allow an undo, but that could complicate displaying the correct name.

Must recalculate all the derived statistics data in small batches in a HostedService running outside the main request, to avoid SQL Timeouts. Must therefore display the standard "Statistics may not update immeditately" banner.

image

@sussexrick sussexrick self-assigned this Feb 3, 2020
@sussexrick sussexrick changed the title Edit and merge player page Team owners can permanently merge players Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant