Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team owners can link player identities #627

Open
8 of 11 tasks
sussexrick opened this issue Sep 28, 2022 · 0 comments
Open
8 of 11 tasks

Team owners can link player identities #627

sussexrick opened this issue Sep 28, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request statistics Player, match or team statistics

Comments

@sussexrick
Copy link
Member

sussexrick commented Sep 28, 2022

This refers to linking multiple identities to a single Player, not permanently merging identities like #118.

  • UX extends the 'Edit player' page of Rename player identities #626. Now it offers 'Include another player in the statistics for [Jane Smith]' with a related item editor to pick a player from the same team.
  • An identity cannot be linked if it is already linked to this or another identity (this might be a longer-term goal but the UI is not feasible for the first iteration).
  • [-] If a team owner is also a club owner, allow them to link any player in the club rather than just the single team. Needs a rethink as you can add any team to your club temporarily, so this would be elevation of privilege to linking any player from any team.
  • In "players linked to my account" show who created the link, "me" or "team owner". Removing an identity linked by a team owner should be unavailable.
  • Similarly team owners cannot break a link created by a member.
  • This will require a new field on PlayerIdentity.
  • Like linking a player to your member account, updates to derived statistics must be done in small batches by a HostedService running in the background. The existing HostedService for linking a player to a member account may already do what's required for this.
  • When linking or unlinking an identity, determine whether it's being done by a team owner or Stoolball England administrator and record that
  • Do not display the context identity in the table of linked identities
  • Update the content page describing the best option for tidying up player lists
  • Review scenarios in my documentation against integration tests
  • Review scenarios in my documentation against UI behaviour
@sussexrick sussexrick added statistics Player, match or team statistics enhancement New feature or request labels Sep 28, 2022
@sussexrick sussexrick pinned this issue Jan 14, 2023
@sussexrick sussexrick self-assigned this Oct 22, 2023
sussexrick added a commit that referenced this issue Oct 28, 2023
sussexrick added a commit that referenced this issue Oct 29, 2023
… / or page name was treated as a different cache key #627
sussexrick added a commit that referenced this issue Oct 29, 2023
sussexrick added a commit that referenced this issue May 5, 2024
sussexrick added a commit that referenced this issue May 5, 2024
@sussexrick sussexrick changed the title Team and club owners can link player identities Team owners can link player identities Sep 24, 2024
sussexrick added a commit that referenced this issue Sep 29, 2024
sussexrick added a commit that referenced this issue Sep 29, 2024
…ect an identity that is already linked to others, because the UI would not tell them to expect the other additions #627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request statistics Player, match or team statistics
Projects
None yet
Development

No branches or pull requests

1 participant