lvm2: Refactor udisks_daemon_util_lvm2_wipe_block()

[tbzatek]

Legacy code, most of the stuff is now offered by the current API.

Fixes #900

[vojtechtrefny]

Looks good to me.

[packit-as-a-service]

Cockpit tests failed for commit 4a73a1f. @martinpitt, @jelly, @mvollmer please check.

[martinpitt]

The testTeardownRetry rawhide failure is worth retrying (/packit retest-failed or click on "Re-run" here). I think it's an unrelated bug.

[tbzatek]

The testTeardownRetry rawhide failure is worth retrying (/packit retest-failed or click on "Re-run" here). I think it's an unrelated bug.

Okay, let's see. It's great that to have this caught by the reverse tests!

RuntimeError: Timed out on 'set -e; [ -e /sys/module/scsi_debug ] || exit 0; for dev in $(ls /sys/bus/pseudo/drivers/scsi_debug/adapter*/host*/target*/*:*/block); do for s in /sys/block/*/slaves/${dev}*; do [ -e $s ] || break; d=/dev/$(dirname $(dirname ${s#/sys/block/})); umount $d || true; dmsetup remove --force $d || true; done; umount /dev/$dev 2>/dev/null || true; done; until rmmod scsi_debug; do sleep 0.2; done'

Would be interesting to dump the state of block devices after such failure. lsblk and perhaps even udisksctl dump to see if there's any mess hanging around.

[tbzatek]

/packit retest-failed

[martinpitt]

@tbzatek That's actually our bug. The generic "after failure" cleanup (with the umount/dmsetup remove etc.) failed because

warning: umount: /mnt: target is busy.

So we have to make the test robust against that, so that the automatic retry has a chance of working. The initial failure was a timeout in the UI. I'll look into that in the next days, sorry for the trouble.

The cockpit test is green now, so not blocked by us (of course a lot of other tests are red)

[tbzatek]

The initial failure was a timeout in the UI. I'll look into that in the next days, sorry for the trouble.

Oh no worries, it's valuable to see how your testing framework works.

Let's merge this then and keep an eye on any related failures.

[martinpitt]

Sent cockpit-project/cockpit#19605 to robustify this.