integration-test: Fix change label test with exfatprogs 1.2.5 #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like VFAT, EXFAT does not allow some characters in the label. Since version 1.2.5 exfatprogs refuses to set a label with those invalid characters. Because this changed in version 1.2.5 we cannot assert that setting such label would throw without knowing the exfatprogs version. While we're touching this part of the test, also document why we're using a shorter label compared to the other filesystems.
|
Can one of the admins verify this patch? |
|
Jenkins, ok to test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like VFAT, EXFAT does not allow some characters in the label. Since version 1.2.5 exfatprogs refuses to set a label with those invalid characters.
Because this changed in version 1.2.5 we cannot assert that setting such label would throw without knowing the exfatprogs version.
While we're touching this part of the test, also document why we're using a shorter label compared to the other filesystems.