Fix handler not working on <button> elements and breaking after first… #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… click 2 changes: 1) The handler was filter only `a` elements with `data-confirm-swal` attributes. It's very common to use `data-confirm` attributes in `button` elements (for instance, on submitting forms, so I removed the `a` restriction, activating the handler on any element that has `data-confirm-swal`. 2) If you have a button that is meant to be clicked more than once, the previous code didn't work. Imagine, for instance, a "delete all" button, that stays fixed in the UI, and when confirmed a partial is updated via ajax .. since the script removed the `data-confirm-swal` after the first click, from the second click onwards the SweetAlert wouldn't be triggered. This pull request stores the previous `data-confirm-swal` in a temp variable, clicks the button (so the infinite Swal loop is avoided), and then (and only then) restaures the sweet alert behavior, so it keeps working for other clicks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… click
2 changes:
The handler was filter only
aelements withdata-confirm-swalattributes. It's very common to usedata-confirmattributes inbuttonelements (for instance, on submitting forms, so I removed thearestriction, activating the handler on any element that hasdata-confirm-swal.If you have a button that is meant to be clicked more than once, the previous code didn't work. Imagine, for instance, a "delete all" button, that stays fixed in the UI, and when confirmed a partial is updated via ajax .. since the script removed the
data-confirm-swalafter the first click, from the second click onwards the SweetAlert wouldn't be triggered. This pull request stores the previousdata-confirm-swalin a temp variable, clicks the button (so the infinite Swal loop is avoided), and then (and only then) restaures the sweet alert behavior, so it keeps working for other clicks.