fix: improve spinner to not hide text and be more CI friendly (#105)

- don't hide 'Getting ...' info message when spinner is shown.
- don't show spinner at all when output is not a TTY

go.mod

@@ -27,14 +27,14 @@ require (
  github.com/jbenet/go-context v0.0.0-20150711004518-d14ea06fba99 // indirect
  github.com/kevinburke/ssh_config v0.0.0-20201106050909-4977a11b4351 // indirect
  github.com/mattn/go-colorable v0.1.12 // indirect
- github.com/mattn/go-isatty v0.0.14 // indirect
+ github.com/mattn/go-isatty v0.0.19 // indirect
  github.com/pmezard/go-difflib v1.0.0 // indirect
  github.com/sergi/go-diff v1.1.0 // indirect
  github.com/spf13/pflag v1.0.5 // indirect
  github.com/xanzy/ssh-agent v0.3.0 // indirect
  golang.org/x/crypto v0.0.0-20210817164053-32db794688a5 // indirect
  golang.org/x/net v0.0.0-20210813160813-60bc85c4be6d // indirect
- golang.org/x/sys v0.0.0-20211205182925-97ca703d548d // indirect
+ golang.org/x/sys v0.6.0 // indirect
  gopkg.in/warnings.v0 v0.1.2 // indirect
  gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b // indirect
 )

go.sum

@@ -305,6 +305,8 @@ github.com/mattn/go-isatty v0.0.11/go.mod h1:PhnuNfih5lzO57/f3n+odYbM4JtupLOxQOA
 github.com/mattn/go-isatty v0.0.12/go.mod h1:cbi8OIDigv2wuxKPP5vlRcQ1OAZbq2CE4Kysco4FUpU=
 github.com/mattn/go-isatty v0.0.14 h1:yVuAays6BHfxijgZPzw+3Zlu5yQgKGP2/hcQbHb7S9Y=
 github.com/mattn/go-isatty v0.0.14/go.mod h1:7GGIvUiUoEMVVmxf/4nioHXj79iQHKdU27kJ6hsGG94=
+github.com/mattn/go-isatty v0.0.19 h1:JITubQf0MOLdlGRuRq+jtsDlekdYPia9ZFsB8h/APPA=
+github.com/mattn/go-isatty v0.0.19/go.mod h1:W+V8PltTTMOvKvAeJH7IuucS94S2C6jfK/D7dTCTo3Y=
 github.com/matttproud/golang_protobuf_extensions v1.0.1/go.mod h1:D8He9yQNgCq6Z5Ld7szi9bcBfOoFv/3dc6xSMkL2PC0=
 github.com/miekg/dns v1.0.14/go.mod h1:W1PPwlIAgtquWBMBEV9nkV9Cazfe8ScdGz/Lj7v3Nrg=
 github.com/miekg/dns v1.1.26/go.mod h1:bPDLeHnStXmXAq1m/Ch/hvfNHr14JKNPMBo3VZKjuso=
@@ -590,6 +592,8 @@ golang.org/x/sys v0.0.0-20211007075335-d3039528d8ac/go.mod h1:oPkhp1MJrh7nUepCBc
 golang.org/x/sys v0.0.0-20211124211545-fe61309f8881/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20211205182925-97ca703d548d h1:FjkYO/PPp4Wi0EAUOVLxePm7qVW4r4ctbWpURyuOD0E=
 golang.org/x/sys v0.0.0-20211205182925-97ca703d548d/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+golang.org/x/sys v0.6.0 h1:MVltZSvRTcU2ljQOhs94SXPftV6DCNnZViHeQps87pQ=
+golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1 h1:v+OssWQX+hTHEmOBgwxdZxK4zHq3yOs8F9J7mk0PY8E=
 golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
 golang.org/x/text v0.0.0-20170915032832-14c0d48ead0c/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=

pkg/logger/logger.go

@@ -2,6 +2,8 @@ package logger
 
 import (
  "fmt"
+ "github.com/mattn/go-isatty"
+ "os"
  "time"
 
  "github.com/briandowns/spinner"
@@ -21,19 +23,32 @@ func Error(format string, a ...interface{}) {
 }
 
 type spinnerWrapper struct {
- *spinner.Spinner
+ spinner *spinner.Spinner
+}
+
+func (s *spinnerWrapper) Stop() {
+ if s.spinner != nil {
+ s.spinner.Stop()
+ }
 }
 
 func (s *spinnerWrapper) Finish() {
- s.Stop()
+ if s.spinner != nil {
+ s.spinner.Stop()
+ }
  fmt.Print("\n")
 }
 
 func InfoWithSpinner(format string, a ...interface{}) *spinnerWrapper {
- s := spinner.New(spinner.CharSets[38], 100*time.Millisecond) // Build our new spinner
  txt := color.GreenString("[INFO] "+format, a...)
  fmt.Print(txt)
- s.Start()
+
+ var s *spinner.Spinner
+ if isatty.IsTerminal(os.Stdout.Fd()) {
+ fmt.Print("\n")
+ s = spinner.New(spinner.CharSets[38], 100*time.Millisecond) // Build our new spinner
+ s.Start()
+ }
 
  return &spinnerWrapper{s}
 }