Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new parameters and globals for a11y #29682

Draft
wants to merge 3 commits into
base: valentin/unified-a11y-testing
Choose a base branch
from

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Nov 21, 2024

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 78.4 MB 78.4 MB 4.11 kB -0.23 0%
initSize 144 MB 144 MB 4.92 kB -0.46 0%
diffSize 65.1 MB 65.1 MB 811 B -0.65 0%
buildSize 6.83 MB 6.84 MB 402 B -0.69 0%
buildSbAddonsSize 1.51 MB 1.51 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.86 MB 1.86 MB 0 B -0.71 0%
buildSbPreviewSize 272 kB 272 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.84 MB 3.84 MB 0 B -0.71 0%
buildPreviewSize 3 MB 3 MB 402 B 0.78 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 24.3s 18s -6s -263ms 0.67 -34.7%
generateTime 17.9s 19.8s 1.8s -0.62 9.2%
initTime 13s 13.5s 511ms -0.99 3.8%
buildTime 8.2s 7.5s -697ms -2.41 🔰-9.2%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.1s 6.3s 227ms 1.13 3.6%
devManagerResponsive 3.8s 3.7s -97ms 0.45 -2.6%
devManagerHeaderVisible 554ms 769ms 215ms 4.24 🔺28%
devManagerIndexVisible 634ms 810ms 176ms 2.97 🔺21.7%
devStoryVisibleUncached 910ms 1.1s 257ms 2.6 🔺22%
devStoryVisible 631ms 811ms 180ms 3.13 🔺22.2%
devAutodocsVisible 543ms 640ms 97ms 3.05 🔺15.2%
devMDXVisible 558ms 430ms -128ms -1.66 🔰-29.8%
buildManagerHeaderVisible 539ms 617ms 78ms 1.14 12.6%
buildManagerIndexVisible 549ms 651ms 102ms 1.42 🔺15.7%
buildStoryVisible 529ms 611ms 82ms 1.14 13.4%
buildAutodocsVisible 464ms 546ms 82ms 5.28 🔺15%
buildMDXVisible 453ms 499ms 46ms 1.22 9.2%

Copy link

nx-cloud bot commented Nov 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3f1ae4e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant