refactor(transformCsf): Simplify makePlayTest function and remove unn…

…ecessary conditional The makePlayTest function in the transformCsf file has been simplified to remove an unnecessary conditional statement. The metaOrStoryPlay parameter is now optional, indicated by the use of the "?" symbol. This change was made to improve code readability and reduce complexity.
storybookjs · Nov 16, 2023 · de631e4 · de631e4
1 parent 1e3e564
commit de631e4
Showing 1 changed file with 9 additions and 14 deletions.
diff --git a/src/csf/transformCsf.ts b/src/csf/transformCsf.ts
@@ -66,7 +66,7 @@ const makePlayTest = ({
 }: {
   key: string;
   title: string;
-  metaOrStoryPlay: t.Node;
+  metaOrStoryPlay?: t.Node;
   testPrefix?: TestPrefixer;
   shouldSkip?: boolean;
 }): t.Statement[] => {
@@ -147,22 +147,17 @@ export const transformCsf = (
     .map((key: string) => {
       let tests: t.Statement[] = [];
       const shouldSkip = skipTags.some((tag) => storyAnnotations[key].tags?.includes(tag));
-      const playFunctions = storyAnnotations[key]?.play;
       if (title) {
         tests = [
           ...tests,
-          ...(playFunctions !== undefined
-            ? [
-                makePlayTest({
-                  key,
-                  title,
-                  metaOrStoryPlay: playFunctions,
-                  testPrefix: testPrefixer,
-                  shouldSkip,
-                }),
-              ]
-            : []),
-        ].flat();
+          ...makePlayTest({
+            key,
+            title,
+            metaOrStoryPlay: storyAnnotations[key]?.play,
+            testPrefix: testPrefixer,
+            shouldSkip,
+          }),
+        ];
       }
 
       if (tests.length) {