Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Remove csf upgrade in nightly check #343

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Aug 15, 2023

It was a hack when needed, which is not the case anymore!

@yannbf yannbf added the skip-release Preserve the current version when merged label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5cce841) 76.66% compared to head (a36fdb4) 76.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #343   +/-   ##
=======================================
  Coverage   76.66%   76.66%           
=======================================
  Files          11       11           
  Lines         180      180           
  Branches       40       40           
=======================================
  Hits          138      138           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

storybook
@yannbf yannbf merged commit 01f49f5 into next Aug 17, 2023
12 checks passed
@yannbf yannbf deleted the yann/remove-csf-upgrade-in-nightly-check branch August 17, 2023 18:04
Copy link

github-actions bot commented Nov 8, 2023

🚀 PR was released in v0.14.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants