Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Node 14 from engines field #353

Merged
merged 8 commits into from
Nov 21, 2023
Merged

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 6, 2023

This is intended to help debug and catch regressions across Node.js versions, as well as making future major upgrades easier.

  • Read single-version CI job versions from .nvmrc
    • Set to currently used version 16
  • Update all external action versions
  • Test all supported major Node.js versions in CI
    • If this seems excessive, proposed alternative: [14.x, 18.x, 20.x] (oldest supported, LTS, newest supported)

Version

Published prerelease version: v0.15.2-next.3

Changelog

🐛 Bug Fix

Authors: 3

@legobeat
Copy link
Contributor Author

legobeat commented Sep 6, 2023

I guess in theory the runner works fine in Node 14 but the test framework requires Node 16 so no way to actually test for that?

@legobeat legobeat force-pushed the ci-node-versions branch 2 times, most recently from c988ac2 to cbcb8e3 Compare October 30, 2023 09:29
@bryanjtc
Copy link
Member

bryanjtc commented Nov 11, 2023

@legobeat In 1 or 2 months, jest v30 will be released and it will drop node 14. Maybe the test-runner should just drop it too.

@yannbf yannbf marked this pull request as ready for review November 21, 2023 08:50
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db1b66a) 80.64% compared to head (7e66afc) 80.64%.

❗ Current head 7e66afc differs from pull request most recent head f52971c. Consider uploading reports for the commit f52971c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #353   +/-   ##
=======================================
  Coverage   80.64%   80.64%           
=======================================
  Files          12       12           
  Lines         217      217           
  Branches       56       56           
=======================================
  Hits          175      175           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yannbf
Copy link
Member

yannbf commented Nov 21, 2023

Hey there! Since Node 14 is out of the picture, I just removed it. I don't think it's a breaking change because the test-runner uses Storybook 7 and it doesn't support Node 14, so I don't think this ever worked. I changed it to test just with Node 16 and 18 on the basic action and node 20 on the extended action. Thanks a lot for this contribution!

@yannbf yannbf added the patch Increment the patch version when merged label Nov 21, 2023
@yannbf yannbf changed the title ci: update actions, widen version coverage Remove Node 14 from engines field Nov 21, 2023
@yannbf yannbf merged commit 53fdd0f into storybookjs:next Nov 21, 2023
9 checks passed
Copy link

🚀 PR was released in v0.15.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants