Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type safety and code quality #383

Merged
merged 11 commits into from
Nov 21, 2023
Merged

Improve type safety and code quality #383

merged 11 commits into from
Nov 21, 2023

Commits on Nov 10, 2023

  1. refactor: Update various files

    - Update test snapshots and test files in the `csf` and `playwright` directories.
    - Update `hooks.ts`, `index.ts`, `transformPlaywright.test.ts`, `transformPlaywright.ts`, `transformPlaywrightJson.test.ts`, `transformPlaywrightJson.ts`, `setup-page.ts`, `test-storybook.ts`, `getCliOptions.test.ts`, `getCliOptions.ts`, `getParsedCliOptions.test.ts`, `getStorybookMain.ts`, `getStorybookMetadata.ts`, `getTestRunnerConfig.test.ts`, `getTestRunnerConfig.ts`, and `tsconfig.json`.
    - These changes were made to improve the codebase and ensure compatibility with the latest dependencies and standards.
    bryanjtc committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    dc692b4 View commit details
    Browse the repository at this point in the history
  2. chore: Update package.json, src/config/jest-playwright.ts, src/csf/tr…

    …ansformCsf.ts, src/playwright/transformPlaywrightJson.ts, and src/typings.d.ts
    
    - Update package.json to include new dependencies or update existing ones.
    - Modify src/config/jest-playwright.ts to configure Jest with Playwright.
    - Refactor src/csf/transformCsf.ts to improve code readability and maintainability.
    - Update src/playwright/transformPlaywrightJson.ts to handle new Playwright JSON format.
    - Update src/typings.d.ts to include new type definitions or modify existing ones.
    bryanjtc committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    ca36a3d View commit details
    Browse the repository at this point in the history
  3. feat(typings): Remove unused __getContext variable

    The __getContext variable was no longer being used in the codebase, so it was removed to improve code cleanliness and maintainability.
    bryanjtc committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    c7b4bed View commit details
    Browse the repository at this point in the history
  4. feat: optimize Storybook configuration and test runner setup

    - Updated the `storyStoreV7` feature in the Storybook configuration to use a more concise expression.
    - Modified the test runner to handle cases where the element handler is null or undefined.
    - Added JSDoc type annotation for the exported Jest configuration.
    bryanjtc committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    351db47 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. Configuration menu
    Copy the full SHA
    8247d70 View commit details
    Browse the repository at this point in the history
  2. refactor: Update getStorybookMain utility functions

    - Refactored getStorybookMain.test.ts and getStorybookMain.ts files.
    - Made improvements to the utility functions for better performance and readability.
    bryanjtc committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    1703067 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Configuration menu
    Copy the full SHA
    e73819e View commit details
    Browse the repository at this point in the history
  2. refactor(playwright): Simplify logic in transformPlaywrightJson.ts

    Simplified the logic in the `transformPlaywrightJson.ts` file to improve readability and maintainability.
    
    - Replaced the double negation with a single negation in the `makeTest` function.
    - Made the `tags` property optional in the `V4Entry` type.
    - Added a default value of `false` for the `metaOrStoryPlay` parameter in the `makeTest` function.
    - Removed the unused import of `TestRunnerConfig` in `test-storybook.ts`.
    bryanjtc committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    1cd32e7 View commit details
    Browse the repository at this point in the history
  3. refactor: Refactor transformPlaywrightJson module and its test file

    This commit includes changes to the transformPlaywrightJson module and its corresponding test file. The purpose of these changes is to refactor the code and improve its overall structure and readability.
    bryanjtc committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    ecc0d29 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Configuration menu
    Copy the full SHA
    be7b73d View commit details
    Browse the repository at this point in the history
  2. fix test

    yannbf committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    049359f View commit details
    Browse the repository at this point in the history