Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #384

Closed
wants to merge 1 commit into from
Closed

Update dependencies #384

wants to merge 1 commit into from

Conversation

bryanjtc
Copy link
Member

@bryanjtc bryanjtc commented Nov 11, 2023

Summary

This pull request introduces significant updates to the project's dependencies and its main index.ts file. With the addition of these dependencies users no longer need to manually install these dependencies to follow the recipes provided in the README.md

File Changes

package.json

  • Dependencies Added:
    • @types/jest-image-snapshot: Version ^5.1.0.
    • axe-playwright: Version ^1.2.3.
    • jest-image-snapshot: Version ^6.2.0.

src/index.ts

  • New Imports and Exports:
    • Imported Config type from @jest/types.
    • Exported several entities from ./playwright/hooks, ./config/jest-playwright, and ./setup-page.
    • Added exports for image snapshot related functions from jest-image-snapshot.
    • Defined and exported JestConfig and GlobalConfig types.
    • Exported various functions related to accessibility testing from axe-playwright, like injectAxe, configureAxe, getAxeResults, etc.

From #323

This commit updates the package.json, src/index.ts, and yarn.lock files. The changes were made to keep the project up to date with the latest dependencies and ensure compatibility with other packages.
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
storybook 7.5.3 None +4 106 kB shilman
@storybook/core-common 7.5.3 network, filesystem, environment +0 79.8 kB shilman

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8247d70) 98.62% compared to head (86c01ae) 98.62%.

Additional details and impacted files
@@              Coverage Diff               @@
##           improve-types     #384   +/-   ##
==============================================
  Coverage          98.62%   98.62%           
==============================================
  Files                 13       13           
  Lines                218      218           
  Branches              50       50           
==============================================
  Hits                 215      215           
  Misses                 3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from improve-types to next November 21, 2023 11:45
@yannbf
Copy link
Member

yannbf commented Nov 21, 2023

Hey @bryanjtc! Thank you for this contribution!

Although this is a pretty neat idea, I believe this doesn't align with our current plans for the test-runner. The recipes exist so users can extend the test-runner and add different testing capabilities to it, based on whatever they like. By making this baked in to the test-runner, it adds a lot of maintenance area for us, and given that jest-playwright-preset is in maintenance mode and there are plans in the future to migrate away from it and use @playwright/test directly instead, the less attached to jest dependencies the test-runner is, the better it will be. I hope you understand and don't mind if I close this PR! We can always revisit this and discuss either here or on discord.

Thank you so much <3

@yannbf yannbf closed this Nov 21, 2023
@bryanjtc
Copy link
Member Author

@yannbf I noticed that there is also a new @storybook/test package that uses vitest. The end goal is for the test-runner to just support @playwright/test and vitest? Isn't there a way to also keep jest?

@yannbf
Copy link
Member

yannbf commented Dec 1, 2023

@yannbf I noticed that there is also a new @storybook/test package that uses vitest. The end goal is for the test-runner to just support @playwright/test and vitest? Isn't there a way to also keep jest?

The idea would be to use @playwright/test only, without Jest or Vitest. It would be as contained as possible. The @storybook/test package is pretty much the same as @storybook/jest in the sense that it only exposes the expect and spy utilities, but now it's from Vitest's internals instead of Jest. I know it's confusing!

cc @kasperpeulen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants