-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #384
Update dependencies #384
Conversation
This commit updates the package.json, src/index.ts, and yarn.lock files. The changes were made to keep the project up to date with the latest dependencies and ensure compatibility with other packages.
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improve-types #384 +/- ##
==============================================
Coverage 98.62% 98.62%
==============================================
Files 13 13
Lines 218 218
Branches 50 50
==============================================
Hits 215 215
Misses 3 3 ☔ View full report in Codecov by Sentry. |
Hey @bryanjtc! Thank you for this contribution! Although this is a pretty neat idea, I believe this doesn't align with our current plans for the test-runner. The recipes exist so users can extend the test-runner and add different testing capabilities to it, based on whatever they like. By making this baked in to the test-runner, it adds a lot of maintenance area for us, and given that jest-playwright-preset is in maintenance mode and there are plans in the future to migrate away from it and use @playwright/test directly instead, the less attached to jest dependencies the test-runner is, the better it will be. I hope you understand and don't mind if I close this PR! We can always revisit this and discuss either here or on discord. Thank you so much <3 |
@yannbf I noticed that there is also a new @storybook/test package that uses vitest. The end goal is for the test-runner to just support @playwright/test and vitest? Isn't there a way to also keep jest? |
The idea would be to use |
Summary
This pull request introduces significant updates to the project's dependencies and its main
index.ts
file. With the addition of these dependencies users no longer need to manually install these dependencies to follow the recipes provided in the README.mdFile Changes
package.json
@types/jest-image-snapshot
: Version^5.1.0
.axe-playwright
: Version^1.2.3
.jest-image-snapshot
: Version^6.2.0
.src/index.ts
Config
type from@jest/types
../playwright/hooks
,./config/jest-playwright
, and./setup-page
.jest-image-snapshot
.JestConfig
andGlobalConfig
types.axe-playwright
, likeinjectAxe
,configureAxe
,getAxeResults
, etc.From #323